[PATCH] Remove SMB_VFS_READ from the VFS.

Ralph Böhme slow at samba.org
Fri May 4 20:34:31 UTC 2018

On Wed, May 02, 2018 at 01:50:51PM -0700, Jeremy Allison wrote:
> Thanks a *lot* Ralph for your help on this.
> Here is the more difficult to review patchset,
> due to the fact it's having to change some
> very old printing code.
> Patchset #1 removes all uses of SMB_VFS_READ
> from source3/printing/nt_printing.c. This is
> *very* old and crustly code, so I started by
> reformatting to modern standards, followed
> by splitting out a monster function into
> several functons called by the now-smaller
> parent, and finally tried to change one
> element at a time to move towards a clean
> set of functions that only call a single
> function - printing_pread_data() - that
> uses read_file(), which takes an offset
> as well as length.
> The reformatting changes no behavior,
> but should make the actual changes
> easier to see and understand.
> Patchset #2 removes SMB_VFS_READ
> from the VFS.
> Please review and push if happy.



Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list