[PATCH] Remove SMB_VFS_READ from the VFS.
jra at samba.org
Wed May 2 20:57:13 UTC 2018
On Wed, May 02, 2018 at 01:50:51PM -0700, Jeremy Allison wrote:
> Thanks a *lot* Ralph for your help on this.
> Here is the more difficult to review patchset,
> due to the fact it's having to change some
> very old printing code.
> Patchset #1 removes all uses of SMB_VFS_READ
> from source3/printing/nt_printing.c. This is
> *very* old and crustly code, so I started by
> reformatting to modern standards, followed
> by splitting out a monster function into
> several functons called by the now-smaller
> parent, and finally tried to change one
> element at a time to move towards a clean
> set of functions that only call a single
> function - printing_pread_data() - that
> uses read_file(), which takes an offset
> as well as length.
> The reformatting changes no behavior,
> but should make the actual changes
> easier to see and understand.
Just as an FYI, if you *really* hate having to
review the reformatting and modern coding
standards changes, I can produce a more
minimal patch that merely modifies the
existing ugly code to achieve the same
effect (calling read_file() instead of
SMB_VFS_LSEEK/SMB_VFS_READ) - but that
would leave a ton of really ugly code
alone (with massive functions and
indentation left as-is).
So currently I prefer my reformatting,
but I'm flexible on this :-).
More information about the samba-technical