[PATCH] build: add option to choose to build with or without JSON audit support
abartlet at samba.org
Thu May 3 08:21:05 UTC 2018
On Thu, 2018-05-03 at 09:49 +0200, Björn Baumbach wrote:
> On 05/02/2018 11:36 PM, Andrew Bartlett wrote:
> > On Wed, 2018-05-02 at 13:43 +0200, Björn Baumbach wrote:
> > > I didn't change the behaviour. The default is still the auto-detection.
> > > In my opinion this feature is an optional feature and I am fine with the
> > > current default.
> > Sure, but in retrospect I'm not. This was missed when we first added
> > the feature.
> > > I would not like to set the default to True.
> > Why is that?
> > A while back we realised that folks were getting builds missing
> > features, so we stopped making krb5 and ldap automatic in this way,
> > requiring an explicit --without-krb5, --without-ldap et al.
> > Now that an explicit option is being added, I'm asking that is match
> > the behaviour of our other 'optional' libraries.
> In my opinion it's not needed to enable all available optional features
> by default. There are some additional switches like the
> --with-json-audit switch:
We should fix those, at least gpgme and libarchive.
> But actually, it's not that important to me. I just like the 'auto'
> default more than 'true', because I like to keep it small.
OK. I'll prepare a patch to handle the others.
> My thoughts were "If I compile with --without-json-audit, Samba will not
> compiled against the jansson libary as well". But yes, you're right -
> mention the --without-json-audit switch is more clear.
> Please find a patch attached.
I'll wrangle the language again once I sort out the configure options,
but we are close.
Thanks for keeping an eye on this and being willing to discuss how we
can improve it.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical