[PATCH] build: add option to choose to build with or without JSON audit support

Björn Baumbach bb at sernet.de
Thu May 3 07:49:49 UTC 2018

On 05/02/2018 11:36 PM, Andrew Bartlett wrote:
> On Wed, 2018-05-02 at 13:43 +0200, Björn Baumbach wrote:
>> I didn't change the behaviour. The default is still the auto-detection.
>> In my opinion this feature is an optional feature and I am fine with the
>> current default. 
> Sure, but in retrospect I'm not.  This was missed when we first added
> the feature.  
>> I would not like to set the default to True.
> Why is that?  
> A while back we realised that folks were getting builds missing
> features, so we stopped making krb5 and ldap automatic in this way,
> requiring an explicit --without-krb5, --without-ldap et al.  
> Now that an explicit option is being added, I'm asking that is match
> the behaviour of our other 'optional' libraries.

In my opinion it's not needed to enable all available optional features
by default. There are some additional switches like the
--with-json-audit switch:


But actually, it's not that important to me. I just like the 'auto'
default more than 'true', because I like to keep it small.

>> In which way would you like to update the man page? The condition "if
>> Samba is compiled against the jansson JSON library" is still correct here:
>>   Authentication and authorization audit information is logged under
>>   the auth_audit, and if Samba is compiled against the jansson JSON
>>   library, a JSON representation is logged under auth_json_audit.
> How about:
> and unless Samba was compiled --without-json-audit, a JSON
> representation is logged under auth_json_audit. 

My thoughts were "If I compile with --without-json-audit, Samba will not
compiled against the jansson libary as well". But yes, you're right -
mention the --without-json-audit switch is more clear.
Please find a patch attached.

Best regards,

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-docs-add-a-hint-to-the-without-json-audit-configure-.patch
Type: text/x-patch
Size: 1352 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180503/e98f34ea/0001-docs-add-a-hint-to-the-without-json-audit-configure-.bin>

More information about the samba-technical mailing list