[PATCH] samba-tool schema attribute query_oc

[William Brown]

On Wed, 2018-05-02 at 13:19 +0200, Stefan Metzmacher via samba-
technical wrote:
> Am 02.05.2018 um 09:25 schrieb Alexander Bokovoy via samba-technical:
> > On ke, 02 touko 2018, William Brown wrote:
> > > On Tue, 2018-05-01 at 10:16 +0300, Alexander Bokovoy wrote:
> > > > On ti, 01 touko 2018, William Brown via samba-technical wrote:
> > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > May be the command would be 'show_oc' rather than
> > > > > > > 'query_oc' as
> > > > > > > we
> > > > > > > have
> > > > > > > already a 'show' command. Just to reduce number of
> > > > > > > alternate
> > > > > > > namings...
> > > > > > 
> > > > > > The alternate naming helps autocomplete, and also makes the
> > > > > > command
> > > > > > "unique". But I certainly also see your point to limit the
> > > > > > "creep".
> > > > > 
> > > > > Ohh if I wasn't clear. I think the current name is good, but
> > > > > I can
> > > > > change if it we really insist.
> > > > 
> > > > I'd like it changed, yes.
> > > >  
> > > 
> > > Done! I have changed this for you and rerun the tests to assert
> > > it
> > > worked.
> > > 
> > > Attaching the full patch series again so that it's easy to apply
> > > them
> > > in order. I'll ask Andrew Bartlett to review these today also.
> > > 
> > > Thanks so much for your time Alex!
> > > 
> > > PS: these can also be found at: 
> > >     https://github.com/Firstyear/samba/tree/configure
> > 
> > These patches look good now. RB+ from my side.
> > 
> > Andrew, are you going to review them as well?
> 
> Just a very high level commend:
> 
> 'samba-tool schema attribute show_oc <attribute>' looks very strance
> with the '_oc'.
> 
> I'd prefer something like:
> 'samba-tool schema attribute objectclasses <attribute>'
> 
> metze
> 

As a native speaker, this comment doesn't sit well with me. The command
needs a verb to indicate the action.

Right now you have as an example:

samba-tool schema attribute show  <attribute>
<noun>     <noun> <noun>   <verb> <noun>

So at least there is some idea of "I'm going to VERB a NOUN which is a
subset of NOUN, NOUN". IE "I'm going to SHOW a UID which is a subset of
ATTRIBUTE, SCHEMA". 

So for this to make sense a verb has to exist.

When I read "schema attribute objectclasses <attribute>", because they
are all noun's I don't know what action will occur.

So this is why I think query or show are important to retain in this
context - I would be open to:

show_oc
show_classes
show_objectclasses
query_oc
query_classes
query_objectclasses

Hope that helps!

Thanks,

William