[PATCH] samba-tool schema attribute query_oc

[Stefan Metzmacher]

Am 02.05.2018 um 09:25 schrieb Alexander Bokovoy via samba-technical:
> On ke, 02 touko 2018, William Brown wrote:
>> On Tue, 2018-05-01 at 10:16 +0300, Alexander Bokovoy wrote:
>>> On ti, 01 touko 2018, William Brown via samba-technical wrote:
>>>>
>>>>>
>>>>>>
>>>>>> May be the command would be 'show_oc' rather than 'query_oc' as
>>>>>> we
>>>>>> have
>>>>>> already a 'show' command. Just to reduce number of alternate
>>>>>> namings...
>>>>>
>>>>> The alternate naming helps autocomplete, and also makes the
>>>>> command
>>>>> "unique". But I certainly also see your point to limit the
>>>>> "creep".
>>>>
>>>> Ohh if I wasn't clear. I think the current name is good, but I can
>>>> change if it we really insist.
>>>
>>> I'd like it changed, yes.
>>>  
>>
>> Done! I have changed this for you and rerun the tests to assert it
>> worked.
>>
>> Attaching the full patch series again so that it's easy to apply them
>> in order. I'll ask Andrew Bartlett to review these today also.
>>
>> Thanks so much for your time Alex!
>>
>> PS: these can also be found at: 
>>     https://github.com/Firstyear/samba/tree/configure
> These patches look good now. RB+ from my side.
> 
> Andrew, are you going to review them as well?

Just a very high level commend:

'samba-tool schema attribute show_oc <attribute>' looks very strance
with the '_oc'.

I'd prefer something like:
'samba-tool schema attribute objectclasses <attribute>'

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/09444149/signature.sig>