[PATCH] Remove SMB_VFS_READ from the VFS.

Jeremy Allison jra at samba.org
Wed May 2 20:50:51 UTC 2018

Thanks a *lot* Ralph for your help on this.

Here is the more difficult to review patchset,
due to the fact it's having to change some
very old printing code.

Patchset #1 removes all uses of SMB_VFS_READ
from source3/printing/nt_printing.c. This is
*very* old and crustly code, so I started by
reformatting to modern standards, followed
by splitting out a monster function into
several functons called by the now-smaller
parent, and finally tried to change one
element at a time to move towards a clean
set of functions that only call a single
function - printing_pread_data() - that
uses read_file(), which takes an offset
as well as length.

The reformatting changes no behavior,
but should make the actual changes
easier to see and understand.

Patchset #2 removes SMB_VFS_READ
from the VFS.

Please review and push if happy.

Thanks !

-------------- next part --------------
A non-text attachment was scrubbed...
Name: read-file.patch
Type: text/x-diff
Size: 57075 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/f629e71d/read-file.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-VFS-Remove-SMB_VFS_READ-function-and-all-implemen.patch
Type: text/x-diff
Size: 12062 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180502/f629e71d/0001-s3-VFS-Remove-SMB_VFS_READ-function-and-all-implemen.diff>

More information about the samba-technical mailing list