[PATCH] net: Add support for a credentials file
abartlet at samba.org
Tue May 1 03:53:42 UTC 2018
On Tue, 2018-05-01 at 04:15 +0100, Olly Betts via samba-technical
> On Tue, May 01, 2018 at 02:40:08PM +1200, Andrew Bartlett via samba-technical wrote:
> > I like the concept, but the addition of another parser for the file
> > worries me.
> I went that route as it made for a smaller patch and the format doesn't
> seem likely to evolve, but it's not ideal (it's actually just a slightly
> adapted version of the parser from cli_credentials_parse_file(), though
> that doesn't really make it better).
> > It would be better if it could either wrap or be wrapped by
> > cli_credentials_parse_file(). Ideally by adding
> > POPT_COMMON_CREDENTIALS to the popt table and reworking the code to use
> > it, just like client.c (for smbclient) does.
> I did look at using POPT_COMMON_CREDENTIALS but there are short
> option clashes with existing net options (-N and -S) and would
> require doing something with the options in POPT_COMMON_CREDENTIALS
> which net doesn't currently support.
-N we can probably work around (only used for groupmap). -S is harder,
perhaps removing that from the popt_common.c side would be best (and
fix source4/lib/cmdline/popt_credentials.c to match).
I'm hesitant about breaking scripts but making this use the common
credentials parsing code is really important (not just for parsing the
file, but for the rest of the things it gives us).
> > I realise this is a lot more work, but we need to unify this rather
> > than see further parser proliferation.
> Given the concept's liked, I think a common parser shouldn't be too much
> work (especially as I forked the existing one).
If you could give using the POPT_COMMON_CREDENTIALS one more try I
would appreciate it. There is a lot we gain if we unify this.
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical