[PATCH] net: Add support for a credentials file
olly at survex.com
Tue May 1 03:15:01 UTC 2018
On Tue, May 01, 2018 at 02:40:08PM +1200, Andrew Bartlett via samba-technical wrote:
> I like the concept, but the addition of another parser for the file
> worries me.
I went that route as it made for a smaller patch and the format doesn't
seem likely to evolve, but it's not ideal (it's actually just a slightly
adapted version of the parser from cli_credentials_parse_file(), though
that doesn't really make it better).
> It would be better if it could either wrap or be wrapped by
> cli_credentials_parse_file(). Ideally by adding
> POPT_COMMON_CREDENTIALS to the popt table and reworking the code to use
> it, just like client.c (for smbclient) does.
I did look at using POPT_COMMON_CREDENTIALS but there are short
option clashes with existing net options (-N and -S) and would
require doing something with the options in POPT_COMMON_CREDENTIALS
which net doesn't currently support.
> I realise this is a lot more work, but we need to unify this rather
> than see further parser proliferation.
Given the concept's liked, I think a common parser shouldn't be too much
work (especially as I forked the existing one).
More information about the samba-technical