[PATCH] Fix a warning in test_smb2_kernel_oplocks8
jonessyue at qnap.com
Fri Mar 30 00:39:29 UTC 2018
Hello Volker, Jeremy,
Sure! Attached is a new patch with simply boolean 'ret' instead of 'ret =
Please review & push. Thanks!
Jones Syue | 薛懷宗
QNAP Systems, Inc.
On Fri, Mar 30, 2018 at 1:58 AM, Jeremy Allison <jra at samba.org> wrote:
> On Thu, Mar 29, 2018 at 01:20:19PM +0200, Volker Lendecke via
> samba-technical wrote:
> > On Thu, Mar 29, 2018 at 06:10:13PM +0800, Jones Syue via samba-technical
> > > Attached is a patch that fixes a warning in test_smb2_kernel_oplocks8,
> > >
> > > torture_assert_goto supposed to use '==' instead of '='.
> > >
> > > Please review & push. Thanks!
> > Patch is of course completely fine,
> > Reviewed-by: Volker Lendecke <vl at samba.org>
> > Stylistically I'd like to avoid "ret==true" and just replace it with
> > "ret" if "ret" is a boolean.
> > Would that be okay for you?
> Reviewed-by: Jeremy Allison <jra at samba.org>
> Both for the original and your changed version !
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 926 bytes
Desc: not available
More information about the samba-technical