[PATCH] Fix a warning in test_smb2_kernel_oplocks8

Jones Syue jonessyue at qnap.com
Fri Mar 30 09:40:03 UTC 2018


 Hello Volker, Jeremy,

Sure! Attached is a new patch with simply boolean 'ret' instead of 'ret =
true',

Please review & push. Thanks!


--
Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.

On Fri, Mar 30, 2018 at 8:39 AM, Jones Syue <jonessyue at qnap.com> wrote:

> Hello Volker, Jeremy,
>
> Sure! Attached is a new patch with simply boolean 'ret' instead of 'ret =
> true',
>
> Please review & push. Thanks!
>
> --
> Regards,
> Jones Syue | 薛懷宗
> QNAP Systems, Inc.
>
> On Fri, Mar 30, 2018 at 1:58 AM, Jeremy Allison <jra at samba.org> wrote:
>
>> On Thu, Mar 29, 2018 at 01:20:19PM +0200, Volker Lendecke via
>> samba-technical wrote:
>> > On Thu, Mar 29, 2018 at 06:10:13PM +0800, Jones Syue via
>> samba-technical wrote:
>> > > Attached is a patch that fixes a warning in test_smb2_kernel_oplocks8,
>> > >
>> > > torture_assert_goto supposed to use '==' instead of '='.
>> > >
>> > > Please review & push. Thanks!
>> >
>> > Patch is of course completely fine,
>> >
>> > Reviewed-by: Volker Lendecke <vl at samba.org>
>> >
>> > Stylistically I'd like to avoid "ret==true" and just replace it with
>> > "ret" if "ret" is a boolean.
>> >
>> > Would that be okay for you?
>>
>> Reviewed-by: Jeremy Allison <jra at samba.org>
>>
>> Both for the original and your changed version !
>>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-s4-torture-kernel-oplocks.-Fix-assertion-warning.patch
Type: application/octet-stream
Size: 926 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180330/6fb51f9e/v2-s4-torture-kernel-oplocks.-Fix-assertion-warning.obj>


More information about the samba-technical mailing list