[PATCH] Fix autobuild for user names starting with c

Christof Schmitt cs at samba.org
Fri Mar 2 15:46:37 UTC 2018


On Tue, Feb 27, 2018 at 12:53:19PM +1300, Andrew Bartlett via samba-technical wrote:
> On Mon, 2018-02-26 at 16:14 -0700, Christof Schmitt via samba-technical 
> wrote:
> > From 1d6900d226fab81e21c3117ca9aabf0329291f0a Mon Sep 17 00:00:00 2001
> > From: Christof Schmitt <cs at samba.org>
> > Date: Mon, 26 Feb 2018 23:58:20 +0100
> > Subject: [PATCH] Fix autobuild for user names starting with c
> > 
> > This is similar to the fix from commit 0b1ba00: Now commit 475a7616 introduced
> > tests that create user names in the form DOMAIN\USER and pass them through
> > shell functions. There "echo" is used to print he username, resulting in
> > /bin/dash on sn-devel to interpret e.g. \c which skips any further output. The
> > result are test exceptions like:
> > 
> > failure: samba4.blackbox.trust_ntlm.Test01 rpcclient lookupnames with LOCALADMEMBER\cs(ad_member:local) [
> > Exception: Exception: LOCALADMEMBER
> > 
> > ]
> > time: 2018-02-26 23:00:46.688800Z
> > 
> > Fix this by replacing the echo with printf %s. This surfaced for
> > test_rpcclient_grep, but apply the same change to all functions in
> > common_test_fns.inc for consistency.
> > 
> > Signed-off-by: Christof Schmitt <cs at samba.org>
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> Please push (so we know it works).

It worked. After two unrelated autobuild failures, the third autobuild
succeeded and the patch is now in master.

Christof



More information about the samba-technical mailing list