[PATCH] Changes to indexing to handle maximum key lengths.

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Fri Mar 2 10:40:16 UTC 2018

I wrote:

> I have reviewed all but the last patch (the 1222 line python test), at
> which point I began to feel very tired. I'll get back to it sometime
> soon. My mostly reviewed branch is here:
> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/gary-lvl1-cu-douglas-review-in-progress

OK, I have RB+'d the last one too. The tests look thorough.
Immaculate formatting too, and Python 3 support is so seamless that

> PY3 = sys.version_info > (3, 0)

is an unused variable.

Good. Thank you Gary.


More information about the samba-technical mailing list