[PATCH] Changes to indexing to handle maximum key lengths.

Andrew Bartlett abartlet at samba.org
Fri Mar 2 18:51:15 UTC 2018


On Fri, 2018-03-02 at 23:40 +1300, Douglas Bagnall wrote:
> I wrote:
> 
> > I have reviewed all but the last patch (the 1222 line python test), at
> > which point I began to feel very tired. I'll get back to it sometime
> > soon. My mostly reviewed branch is here:
> > 
> > http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/gary-lvl1-cu-douglas-review-in-progress
> 
> OK, I have RB+'d the last one too. The tests look thorough.
> Immaculate formatting too, and Python 3 support is so seamless that
> 
> > PY3 = sys.version_info > (3, 0)
> 
> is an unused variable.
> 
> Good. Thank you Gary.
> 
Thanks you Douglas for your patience here, and thanks Gary for the hard work.

I've pushed the patches to autobuild, and so we are now one step closer to LMDB!

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list