[PATCH] Make AD DC build require Jannsson JSON libs, fix fileserver without it
rpenny at samba.org
Sat Jun 23 15:17:18 UTC 2018
On Sat, 23 Jun 2018 16:15:08 +0200
Ralph Böhme via samba-technical <samba-technical at lists.samba.org> wrote:
> On Sat, Jun 23, 2018 at 10:05:00AM +1200, Andrew Bartlett wrote:
> > On Fri, 2018-06-22 at 13:57 -0700, Jeremy Allison wrote:
> > I spent around three hours yesterday building the patch attached,
> > which I could have spent on other things if we had just accepted it
> > as a build requirement overall.
> > - setting up autobuild targets without that feature
> > - wrangling WAF to still link without this feature
> > - fixing the fallback code used in the fileserver
> > - ensuring it still passes tests
> My understanding was that libjansson ought to be an optional feature,
> that is also what is documented here:
> Why did this change? Was this ever discussed? So please calm down,
> I'm just asking if it would be possible. If that causes a big
> maintanance burden and other difficulties then by all means, we can
> add it as a dependency.
> There are already a lot "#ifdef HAVE_JANSSON" all over the place, so
> code wise it just looks like it could be optional and it's just
> missing a few guards.
Ralph, you raised the problem with SLES 11 and RHEL 6 still being
supported, but they both use 3.6.x, which isn't supported by Samba
any more. By my understanding, whatever is decided now will never make
it into the versions of Samba used by SLES 11 and RHEL 6, so what does
it matter if libjansson isn't in their repo's ?
More information about the samba-technical