[PATCH] Make AD DC build require Jannsson JSON libs, fix fileserver without it
slow at samba.org
Sat Jun 23 14:15:08 UTC 2018
On Sat, Jun 23, 2018 at 10:05:00AM +1200, Andrew Bartlett wrote:
> On Fri, 2018-06-22 at 13:57 -0700, Jeremy Allison wrote:
> I spent around three hours yesterday building the patch attached, which
> I could have spent on other things if we had just accepted it as a
> build requirement overall.
> - setting up autobuild targets without that feature
> - wrangling WAF to still link without this feature
> - fixing the fallback code used in the fileserver
> - ensuring it still passes tests
My understanding was that libjansson ought to be an optional feature, that is
also what is documented here:
Why did this change? Was this ever discussed? So please calm down, I'm just
asking if it would be possible. If that causes a big maintanance burden and
other difficulties then by all means, we can add it as a dependency.
There are already a lot "#ifdef HAVE_JANSSON" all over the place, so code wise
it just looks like it could be optional and it's just missing a few guards.
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG Key Fingerprint: FAE2 C608 8A24 2520 51C5
59E4 AA1E 9B71 2639 9E46
More information about the samba-technical