[PATCH] Add winbind request profiling

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Jun 21 14:39:24 UTC 2018


On Thu, Jun 21, 2018 at 04:32:09PM +0200, Stefan Metzmacher wrote:
> Hi Volker,
> 
> if it's ok for you that I squash the attached patch, I'll
> add this to my tevent impersonation tree and make it part of
> a combined tevent 0.9.37. I'll also take the torture test,
> but will defer reviewing the winbindd changes. They can be reviewed
> by someone else if I don't find the time tomorrow and go in
> once 0.9.37 is in master.

I wanted to avoid that double-step, as it impacts every single
tevent_req_create. This is an extremely hot code path and I did not
want to overload it. I have not measured the impact yet, but overall
we should keep the code as streamlined as possible.

If this needs more discussion, we can postpone this patchset. I'm
happy to keep it local and as a customer-specific patch. I know you're
busy to get your tevent patches in, I do not want to step on your
toes.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list