[PATCH] Add winbind request profiling

Stefan Metzmacher metze at samba.org
Thu Jun 21 14:43:25 UTC 2018

Hi Volker,

>> if it's ok for you that I squash the attached patch, I'll
>> add this to my tevent impersonation tree and make it part of
>> a combined tevent 0.9.37. I'll also take the torture test,
>> but will defer reviewing the winbindd changes. They can be reviewed
>> by someone else if I don't find the time tomorrow and go in
>> once 0.9.37 is in master.
> I wanted to avoid that double-step, as it impacts every single
> tevent_req_create. This is an extremely hot code path and I did not
> want to overload it. I have not measured the impact yet, but overall
> we should keep the code as streamlined as possible.
> If this needs more discussion, we can postpone this patchset. I'm
> happy to keep it local and as a customer-specific patch. I know you're
> busy to get your tevent patches in, I do not want to step on your
> toes.

Ok, I'll take it as is.

It's still be possible to do some talloc_reparent tricks to pass the
required talloc parent and then change to the desired memory layout.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180621/f906091c/signature.sig>

More information about the samba-technical mailing list