[PATCH] Improve PSO test flappiness

Andrew Bartlett abartlet at samba.org
Tue Jun 19 22:18:58 UTC 2018


On Tue, 2018-06-19 at 09:00 +0200, Andreas Schneider via samba-
technical wrote:
> On Monday, 18 June 2018 22:54:25 CEST Tim Beale via samba-technical wrote:
> > Hi,
> > 
> > Here are a couple of minor changes that hopefully might make the
> > PSO/password_lockout tests a bit more robust. They basically relax the
> > timing window that the tests use slightly.
> > 
> > It's hard to know for certain because the tests always pass when run
> > locally, and only fail occasionally during a cloud CI run.
> > 
> > CI passed, results here:
> > https://gitlab.com/catalyst-samba/samba/pipelines/24027409
> > 
> > Patch attached, or also here:
> > https://gitlab.com/catalyst-samba/samba/commits/tim-pso-tests
> > 
> > Cheers,
> > Tim
> 
> 
> RB+

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Pushed to autobuild.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list