WAF 2.x upgrade status
abartlet at samba.org
Thu Jul 5 19:54:01 UTC 2018
On Thu, 2018-07-05 at 21:32 +0300, Alexander Bokovoy via samba-
> On to, 05 heinä 2018, Alexander Bokovoy via samba-technical wrote:
> > On to, 05 heinä 2018, Amitay Isaacs wrote:
> > > > > > I'm looking at some ways to mitigate this by setting ONNODE before
> > > > > > running the tests but that doesn't help with the other failure.
> > > > >
> > > > > Attached patch fixes the tests.
> > > > >
> > > > > You can drop the patch that tries to use the installed run_tests.sh
> > > > > (ctdb/wscript: use generated ctdb_run_tests).
> > > >
> > > > Thanks! Do you think we should keep bin in ctdb/?
> > > >
> > >
> > > I'm not sure what the correct thing to do is. Did you change the bin
> > > directory explicitly? Or did that change happen automatically with
> > > waf-2.0?
> > It is result of unification. waf 2.0 has now 'top' and 'out' to point to
> > source and binary build directories. We also use 'top' to find out where
> > buildtools are, so end result is that out is defined as $top/bin.
> > It seems to play well with lib/* libraries.
> > > If it's not too much trouble, then it's easier to do sub-directory
> > > builds (e.g. do tdb or talloc build for testing) and discard them
> > > without having to touch the top-level build.
> > I'll look what could be done to preserve this use case.
> I've got a green run!
> Tomorrow I'll work on fixing up commit messages and will submit the
> patchset for reviews.
In preparation for that I'm running some comparative builds between
master and this branch in the hope that we can confirm no configure or
selftest tests were lost.
I'm doing that on the Rackspace GitLab CI pipelines and an old-style
Catalyst Cloud build.
I'll let you know the results today.
Thanks for all your hard work on this!
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical