PATCH: python3 smb module

David Mulder dmulder at
Tue Jan 30 19:10:00 UTC 2018


Could someone from samba team please review and push?

On 01/18/2018 02:46 AM, Noel Power wrote:
> On 17/01/18 14:56, David Mulder wrote:
>> You have some whitespace problems in source4/libcli/wscript_build
>> In python you should use 4 spaces for indentation and no tabs (you have
>> a couple tabs littered in their). You also have some trailing line
>> whitespace.
> so... I followed the existing convention in this file where 99% of all
> indentation is already tabs. IMO it would look very odd to mix a space
> indentation style with a tab one (especially if the editor configured
> tab spacing is different from the no. spaces used for indentation) Yes,
> I realise the hunk I removed actually did have (mostly) space
> indentation (it was mixed actually)
> I think overall readability should matter here and afaics with the above
> change all the file now has tab indentation, I hope that makes sense.
> I have removed the trailing spaces.  If it really is a problem I can
> change the new code indent spacing to 4 spaces but please consider the
> justification above.
> Noel

David Mulder
SUSE Labs Software Engineer - Samba
dmulder at
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

More information about the samba-technical mailing list