PATCH: python3 smb module

Noel Power nopower at
Thu Jan 18 09:46:00 UTC 2018

On 17/01/18 14:56, David Mulder wrote:
> You have some whitespace problems in source4/libcli/wscript_build
> In python you should use 4 spaces for indentation and no tabs (you have
> a couple tabs littered in their). You also have some trailing line
> whitespace.
so... I followed the existing convention in this file where 99% of all
indentation is already tabs. IMO it would look very odd to mix a space
indentation style with a tab one (especially if the editor configured
tab spacing is different from the no. spaces used for indentation) Yes,
I realise the hunk I removed actually did have (mostly) space
indentation (it was mixed actually)
I think overall readability should matter here and afaics with the above
change all the file now has tab indentation, I hope that makes sense.

I have removed the trailing spaces.  If it really is a problem I can
change the new code indent spacing to 4 spaces but please consider the
justification above.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-libcli-python3-port-for-smb-module.patch
Type: text/x-patch
Size: 3141 bytes
Desc: not available
URL: <>

More information about the samba-technical mailing list