[PATCH] Minor cleanup to libnet_join_member
Volker.Lendecke at SerNet.DE
Thu Jan 25 14:16:45 UTC 2018
On Thu, Jan 25, 2018 at 03:03:56PM +0100, Swen Schillig via samba-technical wrote:
> On Thu, 2018-01-25 at 14:49 +0100, Volker Lendecke via samba-technical
> > On Thu, Jan 25, 2018 at 02:33:12PM +0100, Swen Schillig via samba-
> > technical wrote:
> > > On Thu, 2018-01-25 at 14:16 +0100, David Disseldorp via samba-
> > > technical
> > > wrote:
> > > >
> > > > My preference would be to drop the status assignment at the top
> > > > of
> > > > the
> > > > fn, and keep the "status = NT_STATUS_OK" assignment before the
> > > > "out"
> > > > label. Either way, it looks fine as is.
> > > > Reviewed-by: David Disseldorp <ddiss at samba.org>
> > > >
> > > > Cheers, David
> > > >
> > >
> > > yeah, that's maybe better.
> > > Added some addtl. modifications to the end of the fn.
> > > ...that's it for this one now.
> > Bike-shedding-alert: talloc_move() is higly preferred over
> > talloc_steal() these days...
> > Volker
> I was thinking about it as well, but I didn't see the point to zero
> the "old" variable just before destroying it anyway.
That's true. But TALLOC_FREE instead of talloc_free is overkill in
many places too. It's just careful programming. We want to crash
instead of use-after-free of pointers.
Besuchen Sie die verinice.XP 2018 in Berlin,
Anwenderkonferenz für Informationssicherheit
vom 21.-23.03.2018 im Sofitel Kurfürstendamm
Info & Anmeldung hier: http://veriniceXP.org
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical