[PATCH] Minor cleanup to libnet_join_member
swen at vnet.ibm.com
Thu Jan 25 14:03:56 UTC 2018
On Thu, 2018-01-25 at 14:49 +0100, Volker Lendecke via samba-technical
> On Thu, Jan 25, 2018 at 02:33:12PM +0100, Swen Schillig via samba-
> technical wrote:
> > On Thu, 2018-01-25 at 14:16 +0100, David Disseldorp via samba-
> > technical
> > wrote:
> > >
> > > My preference would be to drop the status assignment at the top
> > > of
> > > the
> > > fn, and keep the "status = NT_STATUS_OK" assignment before the
> > > "out"
> > > label. Either way, it looks fine as is.
> > > Reviewed-by: David Disseldorp <ddiss at samba.org>
> > >
> > > Cheers, David
> > >
> > yeah, that's maybe better.
> > Added some addtl. modifications to the end of the fn.
> > ...that's it for this one now.
> Bike-shedding-alert: talloc_move() is higly preferred over
> talloc_steal() these days...
I was thinking about it as well, but I didn't see the point to zero
the "old" variable just before destroying it anyway.
But if that's really wanted I will update the patch.
More information about the samba-technical