[PATCH]add dns cleanup subcommand for samba-tools

joeg at catalyst.net.nz joeg at catalyst.net.nz
Tue Jan 23 02:51:01 UTC 2018

Hi Andrew,

Thanks for the advice.

Hi all,

I made a new patch, which adds tests to cover CNAME, NS, PTR, SRV, and
multi-valued SRV.

Review appreciated.

Thank you!

Joe Guo

On 16/01/18 13:54, Andrew Bartlett wrote:
> On Tue, 2018-01-16 at 13:37 +1300, joeg at catalyst.net.nz wrote:
>> Hi all,
>> I've add a subcommand for samba-tools to clean up DNS records for a DNS host.
>> This will be helpful when a DNS host is gone while the related DNS records are still there.
>> Can any one help to review this, please?
> Thanks Joe. 
> I think we should have the test prove that a CNAME pointing at this
> name is also cleaned up, as well as a value in a multi-valued SRV
> record.
> A unit test (which I should have written in the first place) for
> remove_dns_references covering all the things it cleans up would also
> be very helpful.
> Thanks!
> Andrew Bartlett

Joe Guo
joeg at catalyst.net.nz
Catalyst IT

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tools-add-dns-cleanup-cmd.patch
Type: text/x-patch
Size: 7799 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180123/0bd1fed0/0001-samba-tools-add-dns-cleanup-cmd.bin>

More information about the samba-technical mailing list