[PATCH]add dns cleanup subcommand for samba-tools

[Andrew Bartlett]

On Tue, 2018-01-23 at 15:51 +1300, joeg at catalyst.net.nz wrote:
> Hi Andrew,
> Thanks for the advice.
> Hi all,
> I made a new patch, which adds tests to cover CNAME, NS, PTR, SRV, and multi-valued SRV.
> Review appreciated.
> Thank you!
> Joe Guo

Thanks Joe.  This is looking great!

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

If I could get a second team reviewer please, it would be great to see
this merged into master.

Andrew Bartlett

> On 16/01/18 13:54, Andrew Bartlett wrote:
> > On Tue, 2018-01-16 at 13:37 +1300, joeg at catalyst.net.nz wrote:
> > > Hi all,
> > > I've add a subcommand for samba-tools to clean up DNS records for a DNS host.
> > > This will be helpful when a DNS host is gone while the related DNS records are still there.
> > > Can any one help to review this, please?
> > 
> > Thanks Joe. 
> > 
> > I think we should have the test prove that a CNAME pointing at this
> > name is also cleaned up, as well as a value in a multi-valued SRV
> > record.
> > 
> > A unit test (which I should have written in the first place) for
> > remove_dns_references covering all the things it cleans up would also
> > be very helpful.
> > 
> > Thanks!
> > 
> > Andrew Bartlett
> > 
>  
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba