[PATCHSET] Add support for fall through attribute

Andrew Bartlett abartlet at samba.org
Tue Jan 16 18:31:44 UTC 2018

On Tue, 2018-01-16 at 15:11 +0100, Andreas Schneider via samba-
technical wrote:
> On Thursday, 21 December 2017 20:00:41 CET Andreas Schneider via samba-
> technical wrote:
> > I'm not sure. Either you need to remove the p++ and FALL_THROUGH or we have
> > to add a break.
> > 
> > However I think we should make the TLDAP test work which currently fails.
> I've talked to Simo, he confirmed that we need to break in this switch 
> statement or we stop parsing in the middle. I've also enabled the TLDAP test.

Did the TLDAP test cover this, that is did it break previously?  It
isn't clear from a skim of the patch. 

If not, could you add such a test case to prove the fix?


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list