[PATCHSET] Add support for fall through attribute

Andreas Schneider asn at samba.org
Wed Jan 17 07:04:21 UTC 2018

On Tuesday, 16 January 2018 19:31:44 CET Andrew Bartlett wrote:
> On Tue, 2018-01-16 at 15:11 +0100, Andreas Schneider via samba-
> technical wrote:
> > On Thursday, 21 December 2017 20:00:41 CET Andreas Schneider via samba-
> > 
> > technical wrote:
> > > I'm not sure. Either you need to remove the p++ and FALL_THROUGH or we
> > > have
> > > to add a break.
> > > 
> > > However I think we should make the TLDAP test work which currently
> > > fails.
> > 
> > I've talked to Simo, he confirmed that we need to break in this switch
> > statement or we stop parsing in the middle. I've also enabled the TLDAP
> > test.
> Did the TLDAP test cover this, that is did it break previously?  It
> isn't clear from a skim of the patch.

Our git webinterface can't show more context. You need to look at the patch 
with more context:


Line 1299 has been added.

If someone can give me an example of a string that function parses we can 
write a unit test with cmocka. However I have no clue about tldap and I don't 
think the TLDAP test we have is the right test to test parsing functions!


Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list