[PATCH v2] fixes account locked when using winbind refresh tickets

David Mulder dmulder at suse.com
Fri Jan 12 21:08:19 UTC 2018


Fixes since version 1:
- Fixed README.Coding issues ("Make use of helper variables")
- Use talloc_strndup instead of strncpy()
- Fix white space in confusing pointer arithmetic.
- Use ads_idmap_cached_connection() to setup ADS_STRUCT
- Prefer the newer DBG_NOTICE over DEBUG(10)
- Add log messages that indicate when a kinit is skipped for a
particular user
- Use strtoull() instead of atoll().
- Put checks within the krb5_ticket_refresh_handler() rekinit goto
block, otherwise the new checks can be jumped over.

 source3/libads/ads_ldap_protos.h       |   2 +
 source3/libads/ldap.c                  |  27 ++++++++
 source3/winbindd/winbindd.h            |   1 +
 source3/winbindd/winbindd_cred_cache.c | 119
++++++++++++++++++++++++++++-----
 source3/winbindd/winbindd_pam.c        |   6 +-
 source3/winbindd/winbindd_proto.h      |   3 +-
 6 files changed, 138 insertions(+), 20 deletions(-)

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winbind-account-locked-when-using-winbind-refresh-ti.patch
Type: text/x-patch
Size: 9840 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180112/2360eab0/0001-winbind-account-locked-when-using-winbind-refresh-ti.bin>


More information about the samba-technical mailing list