Last 3 autobuilds have failed...

[Alexander Bokovoy]

On pe, 12 tammi 2018, Alexander Bokovoy via samba-technical wrote:
> On pe, 12 tammi 2018, Andreas Schneider via samba-technical wrote:
> > On Friday, 12 January 2018 09:04:33 CET Björn JACKE via samba-technical wrote:
> > > On 2018-01-11 at 08:38 -0800 Jeremy Allison via samba-technical sent off:
> > > > [2199(16318)/2230 at 3h40m54s]
> > > > samba.blackbox.wbinfo(ad_member:local)(ad_member:local)
> > > > UNEXPECTED(failure): samba.blackbox.wbinfo(ad_member:local).confirm
> > > > output of wbinfo -i against ad_member(ad_member:local) REASON: Exception:
> > > > Exception: expected
> > > > 'ADDOMAIN/administrator:*:100000:100004:Administrator:/home/ADDOMAIN/Doma
> > > > in Users/administr +ator:/bin/false' or
> > > > 'ADDOMAIN/administrator:*:100000:100004::/home/ADDOMAIN/Domain
> > > > Users/administrator:/bin/false' got 'ADDOMAIN/
> > > > +administrator:*:100000:100004::/home/ADDOMAIN/domain
> > > > users/administrator:/bin/false'
> > > I also got that error a couple of times and it looks a bit frightening. If
> > > the upper/lower case writing of of nss_winbind is eratic, this is calling
> > > for a lot of trouble. Does anybody know what the error might be here? It
> > > wouldn't be good if we ignore this error and it ends up a 4.8 regression
> > > bug finally.
> > 
> > Uppercase lowercase?
> > 
> > There is "Administrator" missing after the forth colon! Could be related to 
> > the last substitute changes!
> No, GECOS field can be empty -- the test actually says about it as it
> expects either existing GECOS or empty one. However, path is including
> lowercased 'domain users' group name but the test expects it intact.
Attached patch normalizes both tested and expected lines to the same
case before comparison. It still reports the original tested and
expected lines in case of an error.

-- 
/ Alexander Bokovoy
-------------- next part --------------
>From 5dc5f3304cdff833c0979b6e3e821502a0bc1e0c Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <ab at samba.org>
Date: Fri, 12 Jan 2018 11:59:12 +0200
Subject: [PATCH] Fix test_wbinfo comparison to be done uniformly

wbinfo output may depend on other options, including normalization
of group or user names. It is better to normalize to one register
(lowcase or uppercase) the tested lines before comparing them to
expected ones.

Signed-off-by: Alexander Bokovoy <ab at samba.org>
---
 nsswitch/tests/test_wbinfo.sh | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/nsswitch/tests/test_wbinfo.sh b/nsswitch/tests/test_wbinfo.sh
index 67660e50fc8..09406bdef60 100755
--- a/nsswitch/tests/test_wbinfo.sh
+++ b/nsswitch/tests/test_wbinfo.sh
@@ -238,7 +238,11 @@ else
 	expected2_line="$DOMAIN/administrator:*:$admin_uid:$gid::/home/$DOMAIN/administrator:/bin/false"
 fi
 
-if test "x$passwd_line" = "x$expected1_line" -o "x$passwd_line" = "x$expected2_line"; then
+_passwd_line=`echo $passwd_line | tr '[:lower:]' '[:upper:]'`
+_expected1_line=`echo $expected1_line | tr '[:lower:]' '[:upper:]'`
+_expected2_line=`echo $expected2_line | tr '[:lower:]' '[:upper:]'`
+
+if test "x$_passwd_line" = "x$_expected1_line" -o "x$_passwd_line" = "x$_expected2_line"; then
 	subunit_pass_test "$test_name"
 else
 	echo "expected '$expected1_line' or '$expected2_line' got '$passwd_line'" | subunit_fail_test "$test_name"
@@ -257,7 +261,10 @@ fi
 
 test_name="confirm output of wbinfo --uid-info against $TARGET"
 subunit_start_test "$test_name"
-if test "x$passwd_line" = "x$expected1_line" -o "x$passwd_line" = "x$expected2_line"; then
+
+_passwd_line=`echo $passwd_line | tr '[:lower:]' '[:upper:]'`
+
+if test "x$_passwd_line" = "x$_expected1_line" -o "x$_passwd_line" = "x$_expected2_line"; then
 	subunit_pass_test "$test_name"
 else
 	echo "expected '$expected1_line' or '$expected2_line' got '$passwd_line'" | subunit_fail_test "$test_name"
-- 
2.14.3