[PR PATCH] Python3: Bulk literal octal number conversion
Douglas Bagnall
douglas.bagnall at catalyst.net.nz
Fri Feb 23 21:14:42 UTC 2018
On 24/02/18 05:17, Github bot account via samba-technical wrote:
> There is a new pull request by noelpower against master on the Samba Samba Github repository
>
> https://github.com/noelpower/samba bulk_literal_octal
> https://github.com/samba-team/samba/pull/132
>
> Python3: Bulk literal octal number conversion
> This patch converts literal octal numbers to a format that is acceptable in both python2 and python3.
> e.g.
>
> convert
> os.chmod(some_path, 0770) # valid in python2 only
> os.chmod(some_path, 0o770) # valid in python2 and python3
>
> The commits follow the same pattern of patch grouping as a previous bulk conversion patch
>
> A patch file from https://github.com/samba-team/samba/pull/132.patch is attached
>
LGTM, but I can't make it apply in combination with the bulk tuple exceptions patch
(in either order). The problems start (and perhaps finish) here:
error: patch failed: python/samba/netcmd/user.py:1970
It'd be nice if you could rework one of them to apply on top of the other.
Douglas
More information about the samba-technical
mailing list