[PR PATCH] Python3: Bulk literal octal number conversion

Andrew Bartlett abartlet at samba.org
Fri Feb 23 23:18:29 UTC 2018

On Sat, 2018-02-24 at 10:14 +1300, Douglas Bagnall via samba-technical
> On 24/02/18 05:17, Github bot account via samba-technical wrote:
> > There is a new pull request by noelpower against master on the Samba Samba Github repository
> > 
> > https://github.com/noelpower/samba bulk_literal_octal
> > https://github.com/samba-team/samba/pull/132
> > 
> > Python3: Bulk literal octal number conversion
> > This patch converts literal octal numbers to a format that is acceptable in both python2 and python3.
> > e.g.
> > 
> > convert
> >            os.chmod(some_path, 0770)      # valid in python2 only
> >            os.chmod(some_path, 0o770)    # valid in python2 and python3
> > 
> > The commits follow the same pattern of patch grouping as a previous bulk conversion patch
> > 
> > A patch file from https://github.com/samba-team/samba/pull/132.patch is attached
> > 
> LGTM, but I can't make it apply in combination with the bulk tuple exceptions patch
> (in either order). The problems start (and perhaps finish) here:
> error: patch failed: python/samba/netcmd/user.py:1970
> It'd be nice if you could rework one of them to apply on top of the other.
> Douglas

Thanks Douglas for checking this out.  

Noel, David et al,

It would be great if all the py3 stuff could be combined, cross-
reviewed by those involved and put in a single pull request.  I'll then
carve out some time to review it (say with Douglas).

I/we can do that more effectively if I have the patches in order,
allowing us to just work down the list and send it off to autobuild in
chunks knowing we won't have to re-work or re-juggle subsequent


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list