[PATCH] samba-tool group list

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Wed Feb 21 20:44:37 UTC 2018

Hi Rowland,

>> Naturally it will need a test before it is merged, but I want to
>> understand the use case a little more as well.
> Oh give over, this is just a switch on an existing samba-tool command,
> it doesn't (in my opinion) need a test. It doesn't change anything in
> AD, it just reads what is already there, but in a slightly different
> way. Just how do you test that ??? 

You could add a method to python/samba/tests/samba_tool/group.py and add
groups as necessary that you'd expect to be listed or not listed, then
make sure you get the results you expect.

As to *why*: it isn't just about showing that the patch works now, it is
about ensuring nobody makes a change in the future that stops it working.


More information about the samba-technical mailing list