[PATCH]add dns cleanup subcommand for samba-tools

joeg at catalyst.net.nz joeg at catalyst.net.nz
Sun Feb 4 21:16:35 UTC 2018


Hi Garming,

This looks great to me, thanks.


On 31/01/18 16:35, Garming Sam via samba-technical wrote:
> I'm okay with putting this patch in, but there's still the caveat which
> isn't mentioned where removed dns host names which have no direct
> records cannot be deleted from SRV records for instance. I would've
> expected the subcommand to have removed those too. Would there be any
> standard cases where the A record would be deleted but not those
> referencing it? In any case, it seems like an expected behaviour. 
>
> I've attached some patches which I think make the command behave as I
> would expect.
>
>
> Cheers,
>
> Garming
>
>
> On 24/01/18 09:45, Andrew Bartlett wrote:
>> Thanks Joe.  This is looking great!
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>> If I could get a second team reviewer please, it would be great to see
>> this merged into master.
>>
>> Andrew Bartlett
>>
>>

-- 
Joe Guo
joeg at catalyst.net.nz
Catalyst IT



More information about the samba-technical mailing list