[RFC] Creation of files in directories with delete-on-close set
slow at samba.org
Sat Feb 3 17:44:30 UTC 2018
On Tue, Jan 30, 2018 at 03:31:29PM -0800, Jeremy Allison wrote:
> On Mon, Jan 15, 2018 at 04:46:57PM +0100, Ralph Böhme wrote:
> > Hi folks,
> > I just came across the fact that smbd does not enforce set delete-on-close on
> > parent directory on file (or directory) creation.
> > Windows server do this check and the s4 ntvfs server does as well.
> > Adding such a check is trivial (cf attached patch), but this oviously has
> > performance implications as it requires an additional record fetch from
> > locking.tdb per create.
> > For protocol completeness, we could add the check but guard it by a default off
> > option.
> > Thoughts?
> Ping. Is this ready to push ? I'm happy with is as it's
> off by default.
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
More information about the samba-technical