[PATCH] Fix bug 13465

[Christof Schmitt]

On Thu, Aug 09, 2018 at 06:05:19PM +0200, Volker Lendecke wrote:
> On Fri, Aug 03, 2018 at 04:39:18PM -0700, Christof Schmitt via samba-technical wrote:
> > Here is an updated patch set based on the above observations. A cluster
> > requires root access and an error message is printed for that case:
> 
> This looks okay. This is probably the best we can achieve given the
> amount of time we can spend on this.
> 
> I started with the review thinking that the client context functions
> should get their own .c/.h files only linked by clients. This very
> likely would mean that the same has to happen for the
> popt_common_credentials_callback. Grepping for POPT_COMMON_CREDENTIALS
> looks okay in this regard. I know this opens a huge can of worms, but
> couldn't this be a chance to clean up that mess a bit?

The client_messaging_context might be interesting as it is assumed to be
the same as the server_messaging_context. A central place where this is
done would be db_open which calls server_messaging_context() to pass the
context to db_open_ctdb. If we wanted to split client and server
context, then this would require modification.

Moving POPT_COMMON_CREDENTIALS might be easier from a first glance.

Christof