[PATCH] Fix bug 13465

[Volker Lendecke]

On Fri, Aug 03, 2018 at 04:39:18PM -0700, Christof Schmitt via samba-technical wrote:
> Here is an updated patch set based on the above observations. A cluster
> requires root access and an error message is printed for that case:

This looks okay. This is probably the best we can achieve given the
amount of time we can spend on this.

I started with the review thinking that the client context functions
should get their own .c/.h files only linked by clients. This very
likely would mean that the same has to happen for the
popt_common_credentials_callback. Grepping for POPT_COMMON_CREDENTIALS
looks okay in this regard. I know this opens a huge can of worms, but
couldn't this be a chance to clean up that mess a bit?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

Meet us at Storage Developer Conference (SDC)
Santa Clara, CA USA, September 24th-27th 2018