[PATCH] Add support for MS Catalog files
asn at samba.org
Thu Aug 9 10:40:25 UTC 2018
On Tuesday, 7 August 2018 23:37:21 CEST Andrew Bartlett wrote:
> On Tue, 2018-08-07 at 12:21 -0700, Jeremy Allison via samba-technical
> > On Tue, Aug 07, 2018 at 11:40:39AM +0200, Andreas Schneider wrote:
> > > Updated patchset attached.
> > >
> > >
> > > Thanks for the review!
> > LGTM. Really nice, clean code - thanks !
> > Reviewed-by: Jeremy Allison <jra at samba.org>
> > However, it adds a dependency on the package libtasn1-bin
> > for the ans1Parser program.
> > You'll need to get root at sn-devel to install that,
> > or change the patch to gate the compilation of this binary on
> > availability of libtasn1-bin, as currently it won't
> > configure without it.
> Also the package list used to build the docker image needs to be
The list has libgnutls28-dev
It depends on:
Manage ASN.1 structures (development)
> Then the docker container needs to be rebuilt (someone just has to re-
> run an ansible script), and the .travis-ci.yml file needs to be
It is be already installed even if you don't have it explicitly in the package
I'm pushing it to master now.
Andreas Schneider asn at samba.org
Samba Team www.samba.org
More information about the samba-technical