[PATCH] Add support for MS Catalog files
asn at samba.org
Wed Aug 8 05:45:50 UTC 2018
On Tuesday, 7 August 2018 23:37:21 CEST Andrew Bartlett wrote:
> On Tue, 2018-08-07 at 12:21 -0700, Jeremy Allison via samba-technical
> > On Tue, Aug 07, 2018 at 11:40:39AM +0200, Andreas Schneider wrote:
> > > Updated patchset attached.
> > >
> > >
> > > Thanks for the review!
> > LGTM. Really nice, clean code - thanks !
> > Reviewed-by: Jeremy Allison <jra at samba.org>
> > However, it adds a dependency on the package libtasn1-bin
> > for the ans1Parser program.
> > You'll need to get root at sn-devel to install that,
> > or change the patch to gate the compilation of this binary on
> > availability of libtasn1-bin, as currently it won't
> > configure without it.
libtasn1 is optional there is no requirement on it. mscat support is built if
libtasn1 is installed in the system and gnutls provides the symbol
If you have a modern gnutls e.g. >= 3.4.7 which we require for the AD DC build
with MIT Kerberos at least, gnutls has a dependency on libtasn1!
> Also the package list used to build the docker image needs to be
If you ever update Ubuntu to a newer version, you probably will get a newer
GnuTLS version which already requires libtasn1. Ubuntu 14.04 has GnuTLS 2,
which is really old. That's like installing Samba 3.6 ...
Andreas Schneider asn at samba.org
Samba Team www.samba.org
More information about the samba-technical