[PATCH v5] fix ctdb_mutex_ceph_rados_helper deadlock

Amitay Isaacs amitay at gmail.com
Wed Aug 8 09:29:49 UTC 2018

On Tue, Aug 7, 2018 at 3:45 AM, David Disseldorp <ddiss at samba.org> wrote:
> On Mon, 6 Aug 2018 15:54:24 +0200, David Disseldorp via samba-technical wrote:
>> > After configuring with install ceph packages I get
>> >
>> >    conf.env['LIBPATH_CEPH-COMMON] = '/ceph'
>> This mirrors the source3/wscript logic added via b2764959200 ("build:
>> fix libceph-common detection").
>> Options.options.LIBDIR only appears to be set if configure --libdir=X is
>> explicitly specified. Using conf.env.libdir instead would likely make
>> more sense, as waf sets it to a sensible default which can then be
>> overridden by an explicit --libdir=X parameter.
> New patchset attached, which adds a new source3/wscript
> Options.options.LIBDIR -> conf.env.LIBDIR change, and updates the
> ctdb/wscript patch (2/5) to do the same.

Now I get

  conf.env.LIBPATH_CEPH-COMMON = '${PREFIX}/lib/ceph'

which is again wrong, since the library is in /usr/lib64/ceph.

I would be happy if you just drop the else part and don't try to guess
anything if libcephfs_dir is not set.

With that change RB+.


More information about the samba-technical mailing list