[PATCH v5] fix ctdb_mutex_ceph_rados_helper deadlock

David Disseldorp ddiss at samba.org
Wed Aug 8 09:56:53 UTC 2018


On Wed, 8 Aug 2018 19:29:49 +1000, Amitay Isaacs via samba-technical wrote:

> On Tue, Aug 7, 2018 at 3:45 AM, David Disseldorp <ddiss at samba.org> wrote:
...
> > New patchset attached, which adds a new source3/wscript
> > Options.options.LIBDIR -> conf.env.LIBDIR change, and updates the
> > ctdb/wscript patch (2/5) to do the same.  
> 
> Now I get
> 
>   conf.env.LIBPATH_CEPH-COMMON = '${PREFIX}/lib/ceph'
> 
> which is again wrong, since the library is in /usr/lib64/ceph.
> 
> I would be happy if you just drop the else part and don't try to guess
> anything if libcephfs_dir is not set.

As it's only affecting the behaviour of the standalone ctdb build, I'm
okay with that. I won't make any changes to the top-level until G√ľnther
has acked them.

> With that change RB+.

Will push later today. Thanks a lot for taking the time to review this,
Amitay

Cheers, David



More information about the samba-technical mailing list