[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Stefan Metzmacher metze at samba.org
Wed Apr 11 08:04:32 UTC 2018

Am 11.04.2018 um 08:24 schrieb Ralph Böhme via samba-technical:
> On Wed, Apr 11, 2018 at 07:48:43AM +0200, Ralph Böhme wrote:
>> This has several acks and no nack, so this version could be pushed if it passes
>> a final review. Thanks!
> just noticed that this version will fail if you git rebase to a version of the
> tree that doesn't have the patchset but the git-hook is in place.
> Attached patchset has an additional check in the hook:
> +if [ ! -f ${gitdir}/script/git-hooks/pre-commit-script ] ; then                                     
> +    exit 0                                       
> +fi                                               
> + 

Why is unset GIT_LITERAL_PATHSPECS not needed in 'pre-commit-script',
but not in 'pre-commit-hook'?

I'd also prefer to have 'set -e' and 'set -u' in (at least)
pre-commit-hook, before it gets install widely.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180411/50b16ef0/signature.sig>

More information about the samba-technical mailing list