[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Martin Schwenke martin at meltin.net
Wed Apr 11 06:45:26 UTC 2018


On Wed, 11 Apr 2018 08:24:56 +0200, Ralph Böhme via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Wed, Apr 11, 2018 at 07:48:43AM +0200, Ralph Böhme wrote:
> > This has several acks and no nack, so this version could be pushed if it passes
> > a final review. Thanks!  
> 
> just noticed that this version will fail if you git rebase to a version of the
> tree that doesn't have the patchset but the git-hook is in place.
> 
> Attached patchset has an additional check in the hook:
> 
> +if [ ! -f ${gitdir}/script/git-hooks/pre-commit-script ] ; then                                     
> +    exit 0                                       
> +fi                                               
> + 
> 

A thing of beauty!  Ship it!  :-)


peace & happiness,
martin



More information about the samba-technical mailing list