[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Swen Schillig swen at vnet.ibm.com
Tue Apr 10 11:09:38 UTC 2018

On Tue, 2018-04-10 at 12:50 +0200, Ralph Böhme via samba-technical
> On Tue, Apr 10, 2018 at 11:36:04AM +0200, Swen Schillig wrote:
> > I promise I will mention it only this one time again, but what
> > about using
> > checkpatch instead of reinventing the wheel ?
> > 
> > checkpatch is used in a variety of other non-kernel projects,
> > like GANESHA (user space NFS server) which is a project with 
> > very similar requirements.
> > 
> > So why not having a look at least ?
> heavens, that's 6k+ lines of Perl and a lot of it is really kernel
> specific.
True, but is it not better to have matured 6k LOC which 
we don't have to maintain vs 500 LOC where we do ?

Besides, the SAMBA project's README.Coding refers explicitly
to the kernel coding style so why not use the utility "they" use ?

Cheers Swen

More information about the samba-technical mailing list