[PATCH for comments] configure: install a whitespace checking pre-commit hook for developers

Ralph Böhme slow at samba.org
Tue Apr 10 10:50:11 UTC 2018

On Tue, Apr 10, 2018 at 11:36:04AM +0200, Swen Schillig wrote:
> I promise I will mention it only this one time again, but what about using
> checkpatch instead of reinventing the wheel ?
> checkpatch is used in a variety of other non-kernel projects,
> like GANESHA (user space NFS server) which is a project with 
> very similar requirements.
> So why not having a look at least ?

heavens, that's 6k+ lines of Perl and a lot of it is really kernel

Simo's proposed patch looks a lot simpler and seems to do what we want as well,
so *if* we adopt such a swiss-army knife tool, I'd prefer Simo's proposal based
on MIT krb5.


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list