Whitespace and bullying
Swen Schillig
swen at vnet.ibm.com
Mon Apr 9 13:08:51 UTC 2018
On Mon, 2018-04-09 at 15:01 +0200, Swen Schillig via samba-technical
wrote:
> On Mon, 2018-04-09 at 22:41 +1000, Martin Schwenke wrote:
> > On Mon, 09 Apr 2018 14:28:45 +0200, Swen Schillig <swen at vnet.ibm.co
> > m>
> > wrote:
> >
> > > On Mon, 2018-04-09 at 21:11 +1000, Martin Schwenke via samba-
> > > technical
> > > wrote:
> > > > Swen's suggestion of using the kernel's checkpatch is
> > > > reasonable,
> > > > but
> > > > the code will require modifications. It doesn't cope with more
> > > > than
> > > > one file in a patch,
> > >
> > > No, what makes you think so ?
> >
> > Sorry, typo. I meant more than 1 commit in a patch file. It barfs
> > because it thinks the Signed-off-by: tags for most of the commits
> > are
> > duplicates.
>
> True.
> But that should be configured/"hard coded" in the git config anyway
> :-)
Besides, if checkpatch is used as a pre-commit hook you don't have
multiple Signed-off-by tags because your only dealing with one patch at
the time.
Correct ?
Cheers Swen
More information about the samba-technical
mailing list