Whitespace and bullying
swen at vnet.ibm.com
Mon Apr 9 13:01:02 UTC 2018
On Mon, 2018-04-09 at 22:41 +1000, Martin Schwenke wrote:
> On Mon, 09 Apr 2018 14:28:45 +0200, Swen Schillig <swen at vnet.ibm.com>
> > On Mon, 2018-04-09 at 21:11 +1000, Martin Schwenke via samba-
> > technical
> > wrote:
> > > Swen's suggestion of using the kernel's checkpatch is reasonable,
> > > but
> > > the code will require modifications. It doesn't cope with more
> > > than
> > > one file in a patch,
> > No, what makes you think so ?
> Sorry, typo. I meant more than 1 commit in a patch file. It barfs
> because it thinks the Signed-off-by: tags for most of the commits are
But that should be configured/"hard coded" in the git config anyway :-)
> Yes, it can be worked around... but I think the kernel checkpatch.pl
> makes too many kernel-related assumptions...
Again true, but that's what a checkpatch.conf could be for,
maybe created by Jeremy and Volker, just to make sure :-)
There are already a few versions out there for projects other than the
kernel. I guess Ronnie mentioned that already.
More information about the samba-technical