Whitespace and bullying

Richard Sharpe realrichardsharpe at gmail.com
Fri Apr 6 20:40:37 UTC 2018

On Fri, Apr 6, 2018 at 1:34 PM, Jeremy Allison via samba-technical
<samba-technical at lists.samba.org> wrote:
> On Fri, Apr 06, 2018 at 10:09:36PM +0200, Ralph Böhme via samba-technical wrote:
>> On Sat, Apr 07, 2018 at 07:59:35AM +1200, Andrew Bartlett wrote:
>> > On Fri, 2018-04-06 at 12:37 -0700, Jeremy Allison wrote:
>> > > Is there a reason you don't want to add the same editor macros
>> > > everyone else uses ?
>> >
>> > You would have to ask Gary, it is his code.  I've added the 80 line
>> > macro, and I'm happy to take a look at others, but first I want us to
>> > seriously consider ditching this.
>> >
>> > Beating up long-standing team members for whitespace violations is
>> > pretty standard these days, but is this really the kind of rule we need
>> > to be enforcing on new contributors?
>> we surely shouldn't beat them up, but should kindly ask them to fix it. For
>> repeat offenders we may have to assing printing bugs. :)
> Some people find following this rule onerous enough that I think Andrew is correct,
> we should use an automated solution here.
> After all, computers are supposed to be our servants, not the
> other way sound :-).

I seem to recall Wireshark has some sort of gerritt hook that checks
for trailing whitespace.

Why not use a commit hook and put it in the git repository.

Richard Sharpe

More information about the samba-technical mailing list