Whitespace and bullying

Swen Schillig swen at vnet.ibm.com
Sat Apr 7 07:58:51 UTC 2018


On Fri, 2018-04-06 at 14:12 -0700, Jeremy Allison via samba-technical
wrote:
> On Fri, Apr 06, 2018 at 10:53:58PM +0200, Ralph Böhme wrote:
> > On Fri, Apr 06, 2018 at 01:51:48PM -0700, Jeremy Allison wrote:
> > > On Fri, Apr 06, 2018 at 10:29:54PM +0200, Ralph Böhme wrote:
> > > > On Fri, Apr 06, 2018 at 01:34:41PM -0700, Jeremy Allison wrote:
> > > > > Some people find following this rule onerous enough that I
> > > > > think Andrew is correct,
> > > > > we should use an automated solution here.
> > > > 
> > > > well, maybe I've been through metze's school of coding for too
> > > > long. One lesson
> > > > you'll learn there: there's exactly one way for a patch to be
> > > > correct. And that
> > > > doesn't include trailing whitespace. :)))
> > > > 
> > > > > After all, computers are supposed to be our servants, not the
> > > > > other way sound :-).
> > > > 
> > > > sure, if this can be automated let's do that, but my
> > > > understanding was that
> > > > there is stuff where trailing whitespace has a purpose, so we
> > > > couldn't automate
> > > > it. Am I missing something?
> > > 
> > > We could enforce on .c and .h files only.
> > 
> > If that's possible, sure.
> 
> I think it should. It only has to look at lines starting with '+'.
> 
What about Linux kernel's checkpatch.pl ?
It could be called via a git-hook [e.g. pre-push] before locally pushed
and therefore it gets checked before it's send to the list.

Cheers Swen




More information about the samba-technical mailing list