[PATCH] Fix trailing whitespace in new (!!!) code

Andrew Bartlett abartlet at samba.org
Fri Apr 6 19:31:16 UTC 2018


On Fri, 2018-04-06 at 14:10 +0200, Volker Lendecke via samba-technical
wrote:
> On Fri, Apr 06, 2018 at 01:54:18PM +0200, Ralph Böhme via samba-technical wrote:
> > On Fri, Apr 06, 2018 at 01:48:34PM +0200, Volker Lendecke via samba-technical wrote:
> > > Attached find a patch that cleans up fresh code to match
> > > README.Coding. Gary, if you review Andrew's code in the future, can
> > > you please point him at the relevant section of README.Coding, quoted
> > > here for your convenience?
> > 
> > I messed this up many times as well, the only thing that helped me to avoid
> > this error was to configure my editor to highlight trailing whitespace. :)
> 
> Back to the original question: Can someone give a formal review, or is
> anything wrong with the patch?

I think it would be better to fix the rule, so I've proposed such a
patch.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list